Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#1668 wrapping of empty chirp error message #1762

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

ljankoschek
Copy link
Contributor

Added "flexShrink: 1" to rightView in TextInputChirp.tsx.
Additionally fixed typo in the empty chirp error Message
Screenshot_20240227_204652

@ljankoschek ljankoschek requested a review from a team as a code owner February 27, 2024 19:56
@ljankoschek ljankoschek linked an issue Feb 27, 2024 that may be closed by this pull request
6 tasks
@CLAassistant
Copy link

CLAassistant commented Feb 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇
5
▀▀▀
6d 7h 17m
▀▀▀▀▀▀
10
▀▀▀▀▀▀▀
MariemBaccari
🥈
4
▀▀▀
1d 17h 15m
▀▀
1
jbsv
🥉
2
1d 7h 33m
0
sgueissa
1
1h 17m
3
▀▀
osm-alt
1
5h 52m
0
ljankoschek
1
20h 9m
0
K1li4nL
1
18m
0
emonnin-epfl
1
6h 45m
1

@ljankoschek ljankoschek force-pushed the work-fe1-ljankoschek-1668-wrap-chirp-errormsg branch from 3153c71 to e8e7e50 Compare February 27, 2024 20:48
Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 27, 2024

@Tyratox
Copy link
Contributor

Tyratox commented Mar 2, 2024

@4xiom5 you were added as a reviewer ;)

Copy link
Contributor

@4xiom5 4xiom5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine.

Copy link
Contributor

@Tyratox Tyratox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, ready to be merged :)

In the future it is appreciated if I am added as a reviewer by the student approving the PR 😄

@ljankoschek ljankoschek merged commit 414bc2a into master Mar 11, 2024
18 checks passed
@ljankoschek ljankoschek deleted the work-fe1-ljankoschek-1668-wrap-chirp-errormsg branch March 11, 2024 09:44
@ljankoschek ljankoschek self-assigned this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Trimmed empty chirps error messages not wrapping
4 participants